On Mon, 31 Aug 2020 12:39:10 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Mon, Aug 31, 2020 at 12:19 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > > On Mon, 31 Aug 2020 12:08:10 +0300 > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > > The driver is quite likely used only on ACPI based platforms and > > > rarely build with CONFIG_ACPI=n. Even though, the few dozens of bytes > > > is better than ugly ifdeffery and inclusion of heavy header. > > > > Given this part is readily available on maker type break out boards > > I doubt it is mostly ACPI. Rest of the comment is fine though. > > In-kernel use seems only ACPI (I grepped for pure SPI driver by name > and didn't find anything). > I hope we will have DT support for that as well (basically means > adding OF ID table). > Good to add the explicit DT support, but I think the nasty fallback is still in place in which the old style ID table is used if we get a match without manufacturer ID. So should be possible to instantiate it from DT even without the table. Jonathan
