On Thu, Aug 20, 2020 at 4:05 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Thu, Aug 20, 2020 at 12:10 PM Alexandru Ardelean > <ardeleanalex@xxxxxxxxx> wrote: > > On Thu, Aug 20, 2020 at 6:04 AM Tian Tao <tiantao6@xxxxxxxxxxxxx> wrote: > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > + struct device *dev = kobj_to_dev(kobj); > And now this can be one line since dev is not used separately. On the other hand perhaps one object per line is better to read. -- With Best Regards, Andy Shevchenko