Re: [PATCH v1 12/16] iio: pressure: hp206c: Use get_unaligned_be24()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 21 Apr 2020 03:31:31 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> This makes the driver code slightly easier to read.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Applied with header added.

Jonathan

> ---
>  drivers/iio/pressure/hp206c.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/pressure/hp206c.c b/drivers/iio/pressure/hp206c.c
> index 3ac3632e7242..d746882eccc8 100644
> --- a/drivers/iio/pressure/hp206c.c
> +++ b/drivers/iio/pressure/hp206c.c
> @@ -93,12 +93,12 @@ static int hp206c_read_20bit(struct i2c_client *client, u8 cmd)
>  	int ret;
>  	u8 values[3];
>  
> -	ret = i2c_smbus_read_i2c_block_data(client, cmd, 3, values);
> +	ret = i2c_smbus_read_i2c_block_data(client, cmd, sizeof(values), values);
>  	if (ret < 0)
>  		return ret;
> -	if (ret != 3)
> +	if (ret != sizeof(values))
>  		return -EIO;
> -	return ((values[0] & 0xF) << 16) | (values[1] << 8) | (values[2]);
> +	return get_unaligned_be24(&values[0]) & GENMASK(19, 0);
>  }
>  
>  /* Spin for max 160ms until DEV_RDY is 1, or return error. */




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux