On Wed, Apr 22, 2020 at 8:42 PM Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> wrote: > > On Wed, Apr 22, 2020 at 10:27 AM Jonathan Cameron > <Jonathan.Cameron@xxxxxxxxxx> wrote: > > > > On Mon, 20 Apr 2020 02:28:47 +0300 > > Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> wrote: > > > > > IIO_CONCENTRATION channel for the DO-SM shouldn't be indexed as > > > there isn't more than one, and also ATLAS_CONCENTRATION_CHANNEL > > > macro scan_index define steps on the IIO_TIMESTAMP channel. > > > > > Fixes: 1a881ed8a43b (iio: chemical: atlas-sensor: add RTD-SM module support) Oops wrong change for Fixes tag. Sorry about that.. Fixes: a751b8e48018 (iio: chemical: atlas-sensor: add DO-SM module support) > > > > Signed-off-by: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> > > > > Fixes tag? > > > > J > > > --- > > > drivers/iio/chemical/atlas-sensor.c | 14 +++++++++++++- > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/chemical/atlas-sensor.c > > > b/drivers/iio/chemical/atlas-sensor.c index > > > 82d470561ad3..7b199ce16ecf 100644 --- > > > a/drivers/iio/chemical/atlas-sensor.c +++ > > > b/drivers/iio/chemical/atlas-sensor.c @@ -194,7 +194,19 @@ static > > > const struct iio_chan_spec atlas_orp_channels[] = { }; > > > > > > static const struct iio_chan_spec atlas_do_channels[] = { > > > - ATLAS_CONCENTRATION_CHANNEL(0, ATLAS_REG_DO_DATA), > > > + { > > > + .type = IIO_CONCENTRATION, > > > + .address = ATLAS_REG_DO_DATA, > > > + .info_mask_separate = > > > + BIT(IIO_CHAN_INFO_RAW) | > > > BIT(IIO_CHAN_INFO_SCALE), > > > + .scan_index = 0, > > > + .scan_type = { > > > + .sign = 'u', > > > + .realbits = 32, > > > + .storagebits = 32, > > > + .endianness = IIO_BE, > > > + }, > > > + }, > > > IIO_CHAN_SOFT_TIMESTAMP(1), > > > { > > > .type = IIO_TEMP, > >