Hello Andy, >> + ret = devm_request_threaded_irq(&client->dev, client->irq, >> + NULL, vcnl4010_irq_thread, >> + IRQF_TRIGGER_FALLING | > >> + IRQF_ONESHOT, > > Isn't it by default when threaded IRQ is asked with NULL for hw handler? No, and it fails with this error message if IRQF_ONESHOT is not set: pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n", Thanks, Mathieu