On Fri, Apr 17, 2020 at 11:49 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Fri, Apr 17, 2020 at 7:24 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote: > > > > It's not uncommon that voltage regulator becomes available later during > > kernel's boot process. This patch adds info message about unavailable > > regulators in a case of the deferred-probe error and also amends the > > error message with a error code. > > > > + if (ret == -EPROBE_DEFER) > > > + dev_info(&i2c->dev, > > + "regulators unavailable, deferring probe\n"); > > I dunno why you think it is worth to spam log with this? > This message will be printed as many times as driver got deferred > probe cycle (maybe dozens in worst case). As you may see in other drivers we usually have the opposite check and print error message in case of != EPROBE_DEFER. > > > + else > > + dev_err(&i2c->dev, "cannot get regulators: %d\n", ret); -- With Best Regards, Andy Shevchenko
