On 3/25/20 9:26 AM, Sa, Nuno wrote:
I also came across with this in ADI internal tree. Did you considered to also split buffer_dma.h into a public and an impl header? Hence, users of buffer_dma do not get access to the internals of buffer.h? That was the approach I suggested in our tree since the split of buffer and buffer_impl is exactly for users not to know about the internals... Or do you think that it's not
At the moment I think there are no users of buffer-dma.h that are not implementations of a buffer. At least in upstream.
There are a few drivers in the ADI tree, which include buffer-dma.h. But this is because they provide their own overloaded implementation for some of the callbacks. In a sense that makes them a buffer implementation. Most of them use the same simple implementation for the overloaded operations. It should be possible to factor this out and use it as a default. Then the include to buffer_dma.h can be removed.
- Lars
