Re: [PATCH v3 4/4] staging: iio: adc: ad7280a: Add comments to clarify stringified arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2020-03-23 at 01:27 +0530, Deepak R Varma wrote:
> [External]
> 
> Checkpatch would flash a check message around a stringified macro
> argument containing a '-' character. Add comment to indicate the
> argument is legitimate and doesn't need fixing.

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>

> 
> Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
> Suggested-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> 
> ---
> 
> Changes since v2:
> 	- None. Patch added in v3
> 
> Changes since v1:
> 	- None. Patch added in v3
> 
>  drivers/staging/iio/adc/ad7280a.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index 19a5f244dcae..bef6bd1295ea 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -824,6 +824,10 @@ static irqreturn_t ad7280_event_handler(int irq, void
> *private)
>  	return IRQ_HANDLED;
>  }
>  
> +/* Note: No need to fix checkpatch warning that reads:
> + *	CHECK: spaces preferred around that '-' (ctx:VxV)
> + * The function argument is stringified and doesn't need a fix
> + */
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
>  			     in_voltage-voltage_thresh_low_value,
>  			     0644,




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux