On Mon, Mar 23, 2020 at 09:40:18AM +0000, Jonathan Cameron wrote: > On Sun, 22 Mar 2020 23:15:13 +0200 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Sun, Mar 22, 2020 at 7:14 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > On Tue, 17 Mar 2020 12:18:09 +0200 > > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: ... > > > > - if (data->use_eoc) > > > > - init_completion(&data->done); > > > > + reinit_completion(&data->done); > > > > > > reinit on the completion when we don't even have an interrupt > > > (hence data->use_eoc == false) seems excessive. Why did > > > you drop the conditional? > > > > It's harmless and gives less code I believe. > > But if you insist I can put it back. > > > > I agree it's harmless but breaks the logical flow by doing > something unnecessary so either we need a comment to say that > or easier option, just put the condition back in. I will do this for v2. Thank you for review! -- With Best Regards, Andy Shevchenko
