Andy, On Mon, 23 Mar 2020 01:44:20 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sun, Mar 22, 2020 at 9:57 PM Deepak R Varma <mh12gx2825@xxxxxxxxx> wrote: > > > > Current implementation of the function ad7192_get_available_filter_freq > > repeats calculation of output data rate a few times. We can simplify > > these steps by refactoring out the calculation of fADC. This would also > > addresses the checkpatch warning of line exceeding 80 character. > > I'm not sure you did an equivalent changes. I believe in the original > code precision is better. Consider low clock frequencies when 10 bit > right shift may hide some bits of the division. Note that those bits are eventually "hidden" in the same way later, despite the different sequence, due to DIV_ROUND_CLOSEST() being used at every step (both before and after the change) without other operations occurring. Anyway, > Care to write a python script to check the precision between old and new code? yes, that would be nice no matter what. -- Stefano
