On Sun, 22 Mar 2020 23:07:00 +0530
Nishant Malpani <nish.malpani25@xxxxxxxxx> wrote:
> On 22/03/20 10:59 pm, Jonathan Cameron wrote:
> > On Mon, 16 Mar 2020 18:46:17 +0100
> > Guido Günther <agx@xxxxxxxxxxx> wrote:
> >
> >> Convert the vcnl4000 device tree bindings to the new YAML format.
> >>
> >> Signed-off-by: Guido Günther <agx@xxxxxxxxxxx>
> > Looks good to me. However, I've made far too many mistakes in
> > DT binding review recently, so will definitely be waiting for Rob to
> > get a chance to look at it!
> >
> > Jonathan
> >
> >> ---
> >> .../bindings/iio/light/vcnl4000.txt | 24 ----------
> >> .../bindings/iio/light/vcnl4000.yaml | 45 +++++++++++++++++++
> >> 2 files changed, 45 insertions(+), 24 deletions(-)
> >> delete mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4000.txt
> >> create mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4000.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/light/vcnl4000.txt b/Documentation/devicetree/bindings/iio/light/vcnl4000.txt
> >> deleted file mode 100644
> >> index 955af4555c90..000000000000
> >> --- a/Documentation/devicetree/bindings/iio/light/vcnl4000.txt
> >> +++ /dev/null
> >> @@ -1,24 +0,0 @@
> >> -VISHAY VCNL4000 - Ambient Light and proximity sensor
> >> -
> >> -This driver supports the VCNL4000/10/20/40 and VCNL4200 chips
> >> -
> >> -Required properties:
> >> -
> >> - -compatible: must be one of :
> >> - vishay,vcnl4000
> >> - vishay,vcnl4010
> >> - vishay,vcnl4020
> >> - vishay,vcnl4040
> >> - vishay,vcnl4200
> >> -
> >> - -reg: I2C address of the sensor, should be one from below based on the model:
> >> - 0x13
> >> - 0x51
> >> - 0x60
> >> -
> >> -Example:
> >> -
> >> -light-sensor@51 {
> >> - compatible = "vishay,vcnl4200";
> >> - reg = <0x51>;
> >> -};
> >> diff --git a/Documentation/devicetree/bindings/iio/light/vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vcnl4000.yaml
> >> new file mode 100644
> >> index 000000000000..74d53cfbeb85
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/light/vcnl4000.yaml
> >> @@ -0,0 +1,45 @@
> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/iio/light/vcnl4000.yaml#
> Shouldn't the devicetree binding document be named with the manufacturer
> part as well?
Yup. Good spot. Told you I kept missing things ;)
Jonathan
>
> With regards,
> Nishant
>
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: VISHAY VCNL4000 ambient light and proximity sensor
> >> +
> >> +maintainers:
> >> + - Peter Meerwald <pmeerw@xxxxxxxxxx>
> >> +
> >> +description: |
> >> + Ambient light sensing with proximity detection over an i2c
> >> + interface.
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - vishay,vcnl4000
> >> + - vishay,vcnl4010
> >> + - vishay,vcnl4020
> >> + - vishay,vcnl4040
> >> + - vishay,vcnl4200
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> +required:
> >> + - compatible
> >> + - reg
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> +- |
> >> + i2c {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + light-sensor@51 {
> >> + compatible = "vishay,vcnl4200";
> >> + reg = <0x51>;
> >> + };
> >> + };
> >> +...
> >
