On Sun, 22 Mar 2020 02:31:52 +0530 Nishant Malpani <nish.malpani25@xxxxxxxxx> wrote: > Provide more suitable format specifiers while printing error logs. > Discards the use of unnecessary explicit casting and prints symbolic > error name which might prove to be convenient during debugging. > > Signed-off-by: Nishant Malpani <nish.malpani25@xxxxxxxxx> > --- > > Based on conversations in [1] & [2]. > > [1] https://marc.info/?l=linux-iio&m=158427554607223&w=2 > [2] https://marc.info/?l=linux-iio&m=158481647605891&w=2 > --- > drivers/iio/accel/kxsd9-i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c > index 38411e1c155b..39a9daa7566f 100644 > --- a/drivers/iio/accel/kxsd9-i2c.c > +++ b/drivers/iio/accel/kxsd9-i2c.c > @@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c, > > regmap = devm_regmap_init_i2c(i2c, &config); > if (IS_ERR(regmap)) { > - dev_err(&i2c->dev, "Failed to register i2c regmap %d\n", > - (int)PTR_ERR(regmap)); > + dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n", > + regmap; Please make sure you do basic build tests. regmap); > return PTR_ERR(regmap); > } >
