On 22/03/20 2:39 am, Joe Perches wrote:
On Sun, 2020-03-22 at 02:31 +0530, Nishant Malpani wrote:
Provide more suitable format specifiers while printing error logs.
Discards the use of unnecessary explicit casting and prints symbolic
error name which might prove to be convenient during debugging.
'Use suitable format specifier' is obscure and not specific.
All the subjects should likely be something like
[PATCH] subsystem: Use vsprintf extension %pe for symbolic error name
Agreed. I was just skeptical about that previously because the commit
subject line's length was going way beyond 50 chars. I do get your point
though; I'll send in a v2!
diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
[]
@@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c,
regmap = devm_regmap_init_i2c(i2c, &config);
if (IS_ERR(regmap)) {
- dev_err(&i2c->dev, "Failed to register i2c regmap %d\n",
- (int)PTR_ERR(regmap));
+ dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
+ regmap;
And this could use a separator between regmap and errname like
dev_err(&i2c->dev, "Failed to register i2c regmap: %pe\n",
or
dev_err(&i2c->dev, "Failed to register i2c regmap - %pe\n",
Yes, I had thought of this but was too timid to ask, thinking it was
perhaps there for legacy reasons :P
I'll add a separator in v2. Thanks for reviewing!
With regards,
Nishant Malpani
