On 3/18/20 8:07 PM, Deepak R Varma wrote:
Address code formatting warnings and check messages flagged by
checkpatch script. Also include another improvement for correcting macro
name typos. Changes intended to improve readability of code.
Changes since v1:
1. Add separate patch for code re-indentation comment
2. Add separate patch for correcting macro names as suggested by
Lars-Peter.
3. Update variable name from sync* to sinc* as suggested by
Stefano.
4. Revert patch intended to add space around "-" operator. It
was a string with a "-" sign further formatted using
stringification. That patch is out of the patchset now.
Deepak R Varma (3):
staging: iio: adc: ad7192: Re-indent enum labels
staging: iio: adc: ad7192: Correct macro names from SYNC to SINC
staging: iio: adc: ad7192: Reformat lines crossing 80 columns
Hi,
The patches all look very good, thanks.
Just one thing, make sure that you base your patches on Jonathan's
latest development tree. The ad7192 drivers was just moved out of
staging 2 weeks ago, so the file path in your patches is no longer
correct. But the patches themselves look good and should be applied
regardless of whether the driver is in staging or not.
See
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=togreg&id=b581f748cce00f4cbd6c76c4f301840403dece7b
for the patch that moved it out of staging.
Jonathan's development tree is the togreg branch from his repository at
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/.
You can add it as an additional remote to your git checkout using
git remote add iio
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
git fetch iio
And then you can reference the dev branch as iio/togreg to for example
rebase your local branch ontop of it.
- Lars
