On Wed, Mar 18, 2020 at 06:50:41AM +0000, Ardelean, Alexandru wrote: > On Tue, 2020-03-17 at 22:17 +0200, Alexandru Lazar wrote: > > [External] > > > > Add driver for the Maxim MAX1241 12-bit, single-channel ADC. The driver > > includes support for this device's low-power operation mode. > > hey, > > overall looks good; > > i'd run ./scripts/checpatch.pl on the patches a bit; > you can run it on the patch file, or on the git commit with > ./scripts/checpatch.pl -g <git-commits> > > i usually do ./scripts/checpatch.pl -g HEAD~2.. [or something like that] before > generating patches; > i sometimes forget to do that; > Another good idea might be to set up a post-commit hook that runs checkpatch for you! Reference: Git post-commit hooks section of https://kernelnewbies.org/FirstKernelPatch Thanks, Rohit
