Re: [PATCH] iio: accel: Add support for the Bosch-Sensortec BMI088

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15-03-2020 13:02, Jonathan Cameron wrote:
On Fri, 13 Mar 2020 15:04:15 +0100
Mike Looijmans <mike.looijmans@xxxxxxxx> wrote:

The BMI088 is a combined module with both accelerometer and gyroscope.
This adds the accelerometer driver support for the SPI interface.
The gyroscope part is already supported by the BMG160 driver.

There doesn't seem to be a specific compatible entry in the bmg160 driver.
Perhaps we should look to add one?

I actually have it already, I'll submit it.



Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx>

For a modern driver I'd normally expect to also see DT bindings.
How are you probing this?

DT bindings, should I submit those as a separate patch?
They're pretty trivial.

There is a lot of half implemented code for features that I assume will follow
in later patches.  Please rip all that out for now.  A simple initial driver
is great but must only include the stuff it actually uses.

I'll do some cleanup, didn't notice that.

Mike.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux