On Sun, Mar 15, 2020 at 12:50:39PM +0000, Jonathan Cameron wrote: > On Fri, 13 Mar 2020 08:59:13 +0530 > Rohit Sarkar <rohitsarkar5398@xxxxxxxxx> wrote: > > > Instead of of_property_read_xxx use device_property_read_xxx as it is > > compatible with ACPI too as opposed to only device tree. > > > > Signed-off-by: Rohit Sarkar <rohitsarkar5398@xxxxxxxxx> > > Look at how this driver is probing from DT. There is another thing you need > to do to make it possible to use PRP001 ACPI based bindings. > > (check what Andy Shevchenko did in a similar patch) > > I'm being deliberately vague as useful for you to understand what is going > on here for yourself :) > > Also, make sure to check you have cc'd everyone relevant. Here you are missing > the driver author. +cc Matt > Jonathan Have sent out a v2 with the required correction, although I still dont completely understand how this ACPI magic works. In the process of going over https://www.kernel.org/doc/Documentation/acpi/enumeration.txt get a better picture. Thanks, Rohit