Re: [PATCH v2 4/8] iio: st_sensors: Drop unneeded casting when print error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 13 Mar 2020 12:49:51 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Explicit casting in printf() usually shows that something is not okay.
> Here, we really don't need it by providing correct specifier.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
applied, thanks.

Jonathan

> ---
> v2: no change
>  drivers/iio/common/st_sensors/st_sensors_i2c.c | 4 ++--
>  drivers/iio/common/st_sensors/st_sensors_spi.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/common/st_sensors/st_sensors_i2c.c b/drivers/iio/common/st_sensors/st_sensors_i2c.c
> index 286830fb5d35..b400560bac93 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_i2c.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_i2c.c
> @@ -49,8 +49,8 @@ int st_sensors_i2c_configure(struct iio_dev *indio_dev,
>  
>  	sdata->regmap = devm_regmap_init_i2c(client, config);
>  	if (IS_ERR(sdata->regmap)) {
> -		dev_err(&client->dev, "Failed to register i2c regmap (%d)\n",
> -			(int)PTR_ERR(sdata->regmap));
> +		dev_err(&client->dev, "Failed to register i2c regmap (%ld)\n",
> +			PTR_ERR(sdata->regmap));
>  		return PTR_ERR(sdata->regmap);
>  	}
>  
> diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c
> index dcbdef4a77f8..ee70515bb89f 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_spi.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_spi.c
> @@ -101,8 +101,8 @@ int st_sensors_spi_configure(struct iio_dev *indio_dev,
>  
>  	sdata->regmap = devm_regmap_init_spi(spi, config);
>  	if (IS_ERR(sdata->regmap)) {
> -		dev_err(&spi->dev, "Failed to register spi regmap (%d)\n",
> -			(int)PTR_ERR(sdata->regmap));
> +		dev_err(&spi->dev, "Failed to register spi regmap (%ld)\n",
> +			PTR_ERR(sdata->regmap));
>  		return PTR_ERR(sdata->regmap);
>  	}
>  




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux