Re: [PATCH 1/2] iio: core: Use scnprintf() for avoiding potential buffer overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 15 Mar 2020 10:54:46 +0100,
Jonathan Cameron wrote:
> 
> On Wed, 11 Mar 2020 08:43:24 +0100
> Takashi Iwai <tiwai@xxxxxxx> wrote:
> 
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buffer limit.  Fix it by replacing with scnprintf().
> 
> Hmm. This is definitely in the somewhat theoretical bug category, but
> given it can be called to print a list of values that is defined
> in a driver, fair enough - it's good protection.
> 
> I'm not going to rush this in given we don't have any drivers
> that are known to run into this.  Hence I've queued it up for
> the togreg branch of iio.git targeting the merge window rather than
> as a fix.

Thanks, that's fine, the patches are just precautions.


Takashi



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux