Re: [PATCH 5/7 v4] mfd: ab8500: augment DT bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 11 Oct 2019 08:44:49 -0500
Rob Herring <robh@xxxxxxxxxx> wrote:

> On Fri, Oct 11, 2019 at 09:18:03AM +0200, Linus Walleij wrote:
> > As we migrate the AB8500 GPADC driver to use IIO, we need to augment
> > the bindings to account for defining the ADC channels in the device
> > tree.
> > 
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > ---
> > ChangeLog v3->v4:
> > - Fix the nodenames from "foo_node" to "foo-node"  
> 
> You forgot to update the example. With that fixed,
Given the number of these, I'm not that comfortable just
fixing this up.  Linus could you do me a follow up patch tiding
up this detail.

I don't want to delay the immutable branch any longer and
would hope the bindings are stable enough that no one will
need this little update in their tree as well as mfd 
(or IIO if Lee doesn't pick up the immutable)

Thanks,

Jonathan

> 
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> 
> > - Remove 0 prefix from @0n to @n
> > ChangeLog v2->v3:
> > - Change "adc-channel@" to "channel@" as per preferred notation.
> > - Add some full stops to the end of sentences.
> > - Reference the new ADC-specific documentation for channel specifier
> >   etc.
> > - Collect Lee's ACK.
> > - Rebased on v5.4-rc1
> > ChangeLog v1->v2:
> > - Rebased on v5.3-rc5
> > ---
> >  .../devicetree/bindings/mfd/ab8500.txt        | 119 ++++++++++++++++++
> >  1 file changed, 119 insertions(+)  




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux