Re: [PULL v2] First set of iio new device support etc for the 5.5 cycle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 12, 2019 at 05:27:44PM +0200, Greg KH wrote:
> On Sat, Oct 12, 2019 at 12:19:46PM +0100, Jonathan Cameron wrote:
> > The following changes since commit b73b93a2af3392b9b7b8ba7e818ee767499f9655:
> > 
> >   iio: adc: ad7192: Add sysfs ABI documentation (2019-09-08 10:34:49 +0100)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-5.5a-take2
> 
> Better, but I see this now:
> 
> drivers/iio/imu/adis.c: In function ‘__adis_check_status’:
> drivers/iio/imu/adis.c:295:9: warning: ‘status’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   295 |  status &= adis->data->status_error_mask;
>       |         ^~
> 
> 
> I'll take this, can you just send a follow-on patch for this?

Also I see:

drivers/iio/imu/adis16480.c: In function ‘adis16480_enable_irq’:
drivers/iio/imu/adis16480.c:950:6: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  950 |  val &= ~ADIS16480_DRDY_EN_MSK;
      |      ^~
  CC [M]  drivers/iio/magnetometer/hmc5843_i2c.o
drivers/iio/imu/adis16480.c: In function ‘adis16480_write_raw’:
drivers/iio/imu/adis16480.c:571:7: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  571 |   val &= ~enable_mask;
      |       ^~
drivers/iio/imu/adis16480.c:557:11: note: ‘val’ was declared here
  557 |  uint16_t val;
      |           ^~~


So did you really fix anything here?

I'll drop this pull again.

What version of gcc are you using?  Might I suggest a newer one (i.e. a
modern one?)

thanks,

greg k-h



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux