Re: [PULL] First set of IIO new device support etc for the 5.5 cycle.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 12 Oct 2019 12:51:19 +0200
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Sat, Oct 12, 2019 at 10:24:36AM +0100, Jonathan Cameron wrote:
> > The following changes since commit b73b93a2af3392b9b7b8ba7e818ee767499f9655:
> > 
> >   iio: adc: ad7192: Add sysfs ABI documentation (2019-09-08 10:34:49 +0100)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-5.5a  
> 
> I'm getting build warnings in drivers/iio/imu/adis16400.c, is that to be
> expected?
> 
> drivers/iio/imu/adis16400.c: In function ‘adis16334_get_freq’:
> drivers/iio/imu/adis16400.c:334:4: warning: ‘t’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   334 |  t >>= ADIS16334_RATE_DIV_SHIFT;
>       |    ^
> drivers/iio/imu/adis16400.c: In function ‘adis16400_get_freq’:
> drivers/iio/imu/adis16400.c:360:11: warning: ‘t’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   360 |  uint16_t t;
>       |           ^
>   CC [M]  drivers/iio/light/bh1750.o
> drivers/iio/imu/adis16400.c: In function ‘adis16400_read_raw’:
> drivers/iio/imu/adis16400.c:557:10: warning: ‘val16’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   557 |  int16_t val16;
>       |          ^~~~~
> drivers/iio/imu/adis16400.c: In function ‘adis16400_write_raw’:
> drivers/iio/imu/adis16400.c:424:14: warning: ‘val16’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   424 |       (val16 & ~0x07) | i);
>       |       ~~~~~~~^~~~~~~~
> drivers/iio/imu/adis16400.c:411:11: note: ‘val16’ was declared here
>   411 |  uint16_t val16;
>       |           ^~~~~
> 
> 
> Can you fix that up first?
> 
> thanks,
> 
> greg k-h
Hi Greg,

I got these as well, but as they weren't the result of anything done
in this series (seems to be GCC 8 getting fussier) I pointed them out
to Alex and he sent a fix.  Was about to queue it up for next series.
I'll tack it on here and send you a new pull in a few mins.

Thanks,

Jonathan




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux