On Tue, 2019-09-17 at 18:09 +0200, Marco Felsch wrote: > [External] > > Hi, > > the main purpose of this serie is to add the pm_ops support. This is > important to free the regulators we are using within the driver. > Hey, Thanks for the patches. There are some minor issues with patch 3 with regard to error paths. Overall they look good. I do have a general comment that maybe ad799x_resume() & ad799x_suspend() could be re-used in ad799x_probe() & ad799x_remove(). Thanks Alex > Regards, > Marco > > Marco Felsch (3): > iio: adc: ad799x: fix probe error handling > iio: adc: ad799x: factor out config register update > iio: adc: ad799x: add pm_ops to disable the device completely > > drivers/iio/adc/ad799x.c | 70 ++++++++++++++++++++++++++++++++++++---- > 1 file changed, 63 insertions(+), 7 deletions(-) >
