On Mon, Sep 2, 2019 at 11:30 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > On Thu, 22 Aug 2019, Linus Walleij wrote: > > + ab8500_btemp : io-channels "btemp_ball" and "bat_ctrl" for measuring the > > + battery voltage > > Voltage? Not temperature? No it is just named like that, super confusing but is in the datasheet and the register description. In drivers/hwmon/ab8500.c, function ab8500_voltage_to_temp() you can see how it is converted into an actual temperature. > > + ab8500_charger : io-channels "main_charger_v", "main_charger_c", "vbus_v", > > + "usb_charger_c" for measuring voltage and current of the > > + different charging supplies > > Are you not a fan of full stops? :) Added some! > Besides this, looks okay in general: > > For my own reference: > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> Should I record that as just Acked-by: when I resend or do you want me to record the infix when resending for clarity? Yours, Linus Walleij
