On Mon, Aug 26, 2019 at 10:51 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On Thu, 22 Aug 2019 16:52:33 +0200
> Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> > This adds the IIO channels for the GPADC after converting it
> > to using the standard IIO ADC bindings and moving the driver
> > over to the IIO subsystem. We also add IIO hwmon standard
> > driver node to support reading channels in a standard manner.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> I'll ask the 'stupid' question. Doesn't this break compatibility
> with old DTs?
No we just add stuff, if the kernel *want* to, it can implement fallbacks
for old device trees (which I guess is to hardcode all the channels into the
drivers and not use IIO ADC, like we did before in Linux). I do not do that
however, but "some operating system" could very well do it, and that
is the DT design ambition.
> One comment inline to do with IIO standardization that occurred in
> the meantime.
(...)
> > + /* GPADC channels */
> > + bat_ctrl: adc-channel@01 {
> > + reg = <0x01>;
>
> We standardised recently on just channel@01 etc
OK I fix this when applying.
Thanks!
Linus Walleij
