On 2019/8/26 1:59, Jonathan Cameron wrote:
> On Fri, 23 Aug 2019 20:18:52 +0800
> YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
>> IIO_ST_SENSORS_CORE select IIO_ST_SENSORS_I2C
>> unconditionally, if REGMAP_I2C is not set, build fails
>>
>> drivers/iio/common/st_sensors/st_sensors_i2c.o: In function `st_sensors_i2c_configure':
>> st_sensors_i2c.c:(.text+0x58): undefined reference to `__devm_regmap_init_i2c'
>>
>> This patch selects REGMAP_I2C to fix it.
>> IIO_ST_SENSORS_SPI is similar to SPI issue.
>>
>> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
>> Fixes: 062809ef7733 ("iio: make st_sensors drivers use regmap")
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Hi,
>
> Thanks, I've fixed up the inconsistent ordering below.
Oh, thanks!
>
> Applied to the togreg branch of iio.git and pushed out as
> testing for the autobuilders to play with it.
>
> Thanks,
>
> Jonathan
>
>> ---
>> drivers/iio/common/st_sensors/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/iio/common/st_sensors/Kconfig b/drivers/iio/common/st_sensors/Kconfig
>> index 91b98e1..16d973f 100644
>> --- a/drivers/iio/common/st_sensors/Kconfig
>> +++ b/drivers/iio/common/st_sensors/Kconfig
>> @@ -5,8 +5,10 @@
>>
>> config IIO_ST_SENSORS_I2C
>> tristate
>> + select REGMAP_I2C
>>
>> config IIO_ST_SENSORS_SPI
>> + select REGMAP_SPI
>
> Inconsistent with the previous.
>
>> tristate
>>
>> config IIO_ST_SENSORS_CORE
>
>
> .
>
