Re: [PATCH] iio:light:noa1305: Fix missing break statement.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 8/13/19 8:58 AM, Greg KH wrote:
> On Tue, Aug 13, 2019 at 09:38:51PM +0800, Jonathan Cameron wrote:
>> This got caught by the implicit fall through detection but is
>> a bug rather than missing marking.
>>
>> Reported-by: 0-DAY kernel test infrastructure
>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>> Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305")
>> ---
>>  drivers/iio/light/noa1305.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
>> index 7b859ae1044d..5ebfbc52f541 100644
>> --- a/drivers/iio/light/noa1305.c
>> +++ b/drivers/iio/light/noa1305.c
>> @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2)
>>  	case NOA1305_INTEGR_TIME_400MS:
>>  		*val = 100;
>>  		*val2 = 77 * 4;
>> +		break;
>>  	case NOA1305_INTEGR_TIME_200MS:
>>  		*val = 100;
>>  		*val2 = 77 * 2;
>> -- 
>> 2.20.1
>>
> 
> Gustavo, your work caught a bug _before_ it hit Linus's tree this time :)
> 

This is so great! I think I can now officially say: mission accomplished.

Thanks for sharing this with me. It made my day. :)

--
Gustavo



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux