On Sun, 7 Jul 2019 13:01:06 +0100
Jonathan Cameron <jonathan.cameron@xxxxxxxxxx> wrote:
> +CC Matt as it's his driver. His latest email is in .mailmap.
Bump for Matt. Please give this one a quick look.
Thanks,
Jonathan
>
> Jonathan
>
>
> On Fri, 5 Jul 2019 16:43:55 +0300
> Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote:
>
> > The iio_triggered_buffer_{predisable,postenable} functions attach/detach
> > the poll functions.
> >
> > The iio_triggered_buffer_predisable() should be called last, to detach the
> > poll func after the devices has been suspended.
> >
> > The position of iio_triggered_buffer_postenable() is correct.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> > ---
> > drivers/iio/chemical/atlas-ph-sensor.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> > index 3a20cb5d9bff..6c175eb1c7a7 100644
> > --- a/drivers/iio/chemical/atlas-ph-sensor.c
> > +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> > @@ -323,16 +323,16 @@ static int atlas_buffer_predisable(struct iio_dev *indio_dev)
> > struct atlas_data *data = iio_priv(indio_dev);
> > int ret;
> >
> > - ret = iio_triggered_buffer_predisable(indio_dev);
> > + ret = atlas_set_interrupt(data, false);
> > if (ret)
> > return ret;
> >
> > - ret = atlas_set_interrupt(data, false);
> > + pm_runtime_mark_last_busy(&data->client->dev);
> > + ret = pm_runtime_put_autosuspend(&data->client->dev);
> > if (ret)
> > return ret;
> >
> > - pm_runtime_mark_last_busy(&data->client->dev);
> > - return pm_runtime_put_autosuspend(&data->client->dev);
> > + return iio_triggered_buffer_predisable(indio_dev);
> > }
> >
> > static const struct iio_trigger_ops atlas_interrupt_trigger_ops = {
>
>
