On Fri, 7 Jun 2019 18:13:27 -0700 Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > Hi all, > > there are currently two drivers for ADS1015 in the linux kernel: > > drivers/iio/adc/ti-ads1015.c > drivers/hwmon/ads1015.c > > The driver in the iio subsystem provides more flexible support for > the chip's capabilities. Even if the hwmon driver is removed, > the iio->hwmon bridge can still be used and would provide the same > information as before to the user. Existing devicetree entries > for ads1015 both point to the iio driver. The platform include file > is only included by the drivers, but not from any platform code. > > With that in mind, keeping the hwmon driver around does not really > add value. I suggest to remove it. Are there any objections or > concerns ? It is probably not worth the dance of creating a stub driver in hwmon to bring up the iio->hwmon bridge but that might be an option if anyone minds just dropping the ads1015 hwmon driver. Thanks, Jonathan > > Thanks, > Guenter