On 2019-06-06 4:09 a.m., Ardelean, Alexandru wrote: > On Wed, 2019-06-05 at 15:07 -0600, Robert Hancock wrote: >> [External] >> >> >> Since the XADC logic can be used with standalone Xilinx FPGAs, this driver >> can potentially be used with various ARM platforms, not just Zynq. >> Change the Zynq dependency to ARM in the list of supported platforms >> in the Kconfig dependencies for this driver. > > To my knowledge, there are 3 FPGA platforms with ARM supported in Linux. > And symbols are ARCH_ZYNQ, ARCH_ZYNQMP & ARCH_SOCFPGA. > For these ARM + FPGA SoCs, it is usually preferred to list the supported/tested ARM + FPGA platforms in Kconfig. > > I am curious: are you using something that isn't in the above list? Yes, we are using the XADC on a Kintex-7 FPGA through a PCIe to AXI bridge using an iMX6D platform - not an integrated ARM+FPGA. Using such an approach this driver could potentially be used on just about any platform, but I didn't want to open it up too much for now in case of some compile issues. > > Thanks > Alex > >> >> Signed-off-by: Robert Hancock <hancock@xxxxxxxxxxxxx> >> --- >> drivers/iio/adc/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig >> index f96a770..93863bb 100644 >> --- a/drivers/iio/adc/Kconfig >> +++ b/drivers/iio/adc/Kconfig >> @@ -1085,7 +1085,7 @@ config VIPERBOARD_ADC >> >> config XILINX_XADC >> tristate "Xilinx XADC driver" >> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST >> + depends on ARM || MICROBLAZE || COMPILE_TEST >> depends on HAS_IOMEM >> select IIO_BUFFER >> select IIO_TRIGGERED_BUFFER >> -- >> 1.8.3.1 >> -- Robert Hancock Senior Software Developer SED Systems, a division of Calian Ltd. Email: hancock@xxxxxxxxxxxxx
