On Mon, Mar 18, 2019 at 10:27:57AM +0800, Phil Reid wrote: > On 18/03/2019 4:53 am, Vladimir Petrigo wrote: > >Signed-off-by: Vladimir Petrigo <vladimir.petrigo@xxxxxxxxx> > >--- > > drivers/staging/iio/adc/ad7192.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > >index acdbc07..7c632cf 100644 > >--- a/drivers/staging/iio/adc/ad7192.c > >+++ b/drivers/staging/iio/adc/ad7192.c > >@@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, > > } > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > >- in_voltage-voltage_scale_available, > >+ in_voltage - voltage_scale_available, > > 0444, ad7192_show_scale_available, NULL, 0); > > static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, > > > G'day Vladimir , > > This is not a mathematical op. > It gets passed to __ATTR() macro and converted to a string. > > > -- > Regards > Phil Hello Phil, Thank you for the prompt reply. Should I remove that changes from the patchset v2 then? -- Best regards, Vladimir