On Fri, Mar 08, 2019 at 05:46:24PM -0500, Sven Van Asbroeck wrote: > On Fri, Mar 8, 2019 at 5:33 PM Tomasz Duszynski <tduszyns@xxxxxxxxx> wrote: > > > > > > So perhaps that change deserves a separate patch because it smells like > > a code cleanup. > > Not really. This patch fixes the order in which resources are torn > down on release(). What I meant is that delayed work initialization could stay where it was. The reason you moved it is readability improvement so to me it is more of a cleanup hence I suggested a separate patch. Up to you. > You do this by fixing the order by which devm-resources are allocated > on probe(). > > So it's a fundamental use-after-free fix, and not really a cleanup. > But I'm happy to split into multiple patches if you want ?
