On Mon, 18 Feb 2019 14:22:35 -0300 Lucas Oshiro <lucasseikioshiro@xxxxxxxxx> wrote: > Invert if statement arms in line 214, in order to make the code cleaner > > Signed-off-by: Lucas Oshiro <lucasseikioshiro@xxxxxxxxx> > Signed-off-by: Anderson Reis <andersonreisrosa@xxxxxxxxx> Given this undoes one of the earlier changes, please merge them. Jonathan > --- > drivers/iio/potentiostat/lmp91000.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c > index 6dba26121a62..7229ef59590a 100644 > --- a/drivers/iio/potentiostat/lmp91000.c > +++ b/drivers/iio/potentiostat/lmp91000.c > @@ -211,12 +211,11 @@ static int lmp91000_read_config(struct lmp91000_data *data) > > ret = of_property_read_u32(np, "ti,tia-gain-ohm", &val); > if (ret) { > - if (of_property_read_bool(np, "ti,external-tia-resistor")) { > - val = 0; > - } else { > + if (!of_property_read_bool(np, "ti,external-tia-resistor")) { > dev_err(dev, "no ti,tia-gain-ohm defined"); > return ret; > } > + val = 0; > } > > ret = -EINVAL;