Re: [PATCH] drivers: iio: industrialio-core: add check when kzalloc fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2019 at 4:28 PM Bharath Vedartham <linux.bhar@xxxxxxxxx> wrote:
>
> add code to handle the case when kzalloc fails to allocate memory to dev
>
> Signed-off-by: Bharath Vedartham <linux.bhar@xxxxxxxxx>
> ---
>  drivers/iio/industrialio-core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 4f5cd9f..93caa6b 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1475,6 +1475,8 @@ struct iio_dev *iio_device_alloc(int sizeof_priv)
>                 }
>                 dev_set_name(&dev->dev, "iio:device%d", dev->id);
>                 INIT_LIST_HEAD(&dev->buffer_list);
> +       } else {
> +               return NULL;

I'd argue that this is a bit redundant, because `dev` is NULL, the
return below (return dev) will also return NULL.

Alex

>         }
>
>         return dev;
> --
> 2.7.4
>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux