On Fri, Aug 17, 2018 at 12:03:19PM -0700, David Frey wrote: > Temperature, pressure and humidity all expose and oversampling setting > that works in the same way. Provide common handling for the > oversampling sysfs attributes. > > Signed-off-by: David Frey <dpfrey@xxxxxxxxx> Reviewed-by: Himanshu Jha <himanshujha199640@xxxxxxxxx> Tested-by: Himanshu Jha <himanshujha199640@xxxxxxxxx> Also, 0-day tested with build success! Thanks With this I don't think my patch: https://lore.kernel.org/lkml/20180811102636.6171-1-himanshujha199640@xxxxxxxxx/ is useful any more since bme680_is_valid_oversampling() does the work pehaps. The best part of this patch is supplying direct values and removes the amiguity around ilog2(), especially at probe, when supplying default values. Thanks David for the series. -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
