On Tue, Aug 07, 2018 at 01:07:20PM -0700, David Frey wrote: > * use consistent naming for masks. _MSK -> _MASK > * use GEN_MASK to define masks rather than hex constants > * consistently indent masks and values under the corresponding register > define > * use FIELD_GET instead of explicit mask and shift > * Join split lines in bme680_read_calib() which can fit in 80 chars > * Make use clamp macro > > Signed-off-by: David Frey <dpfrey@xxxxxxxxx> > --- This patch is fine but ideally it should be split for each change. "One patch per change policy!" Dan is on vacation I guess otherwise he must have poked you before me ;) Also, please consider making subject: "iio: chemical: bme680: .... .. " Once you roll a v2, I will get it tested on my sensor. And yes, please also CC Jonathan <jic23@xxxxxxxxxx> so that it doesn't get lost. Thanks for making the effort, David! -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
