On Sat, 21 Jul 2018 21:06:08 +0530 Himanshu Jha <himanshujha199640@xxxxxxxxx> wrote: > > Hi Himanshu, > > > > This was close to the point where I'd take it and make the few remaining > > fixes myself. I'm still bothered however by the fact the casts in the > > various calibration functions are still not all justified so please take > > another look at that. Frankly it looks like the original author > > threw in casts because they didn't want to have to think about which ones > > actually do anything! > > Ok. I will remove the ones mentioned below. > > > Few other things to fix up for v5 as well. > > I will send the fixes in an hour. > > > Jonathan > > > > > > > +#define BME680_NB_CONV_MASK GENMASK(3, 0) > > > +#define BME680_RUN_GAS_EN_BIT BIT(4) > > > > odd looking spacing above. > > I don't know why this is showing like that in the diff output, but I > have checked the code by apllying to my test tree(git am <patch>) and > there was no such spurious spacing! You have a tab after the #define in this one instance - in the others it's all spaces (as it should be) ... -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
