On Mon, 3 Jul 2017 15:50:14 +0300
Mikko Koivunen <mikko.koivunen@xxxxxxxxxxxxxxxxx> wrote:
> Change iio_device_register to devm_
>
> --
>
> drivers/iio/light/rpr0521.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c
> index a6efa126..4c090d0 100644
> --- a/drivers/iio/light/rpr0521.c
> +++ b/drivers/iio/light/rpr0521.c
> @@ -1029,7 +1029,7 @@ static int rpr0521_probe(struct i2c_client *client,
> }
> }
>
> - ret = iio_device_register(indio_dev);
> + ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
> if (ret)
> goto err_pm_disable;
>
> @@ -1049,8 +1049,6 @@ static int rpr0521_remove(struct i2c_client *client)
> {
> struct iio_dev *indio_dev = i2c_get_clientdata(client);
>
> - iio_device_unregister(indio_dev);
> -
Given this now means you turn the power off before you remove the userspace
interfaces (and in kernel ones) this is a very bad idea.
So dropping this patch.
Thanks,
Jonathan
> pm_runtime_disable(&client->dev);
> pm_runtime_set_suspended(&client->dev);
> pm_runtime_put_noidle(&client->dev);
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
