On Wed, 28 Jun 2017 23:53:10 +0200 Angelo Compagnucci <angelo.compagnucci@xxxxxxxxx> wrote: > Some part of the configuration are not touched after the probe > and if something goes wrong on writing the initial one, > the chip will misbehave. > Adding an error checking ensures that the inital configuration will > be written correctly. Moreover ensures that a sensible configuration > will be saved in driver data and used subsequently as intended. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@xxxxxxxxx> Applied to the togreg branch of iio.git and pushed out as testing. Added a reported by for Maarten. Jonathan > --- > drivers/iio/adc/mcp3422.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c > index 6737df8..63de705 100644 > --- a/drivers/iio/adc/mcp3422.c > +++ b/drivers/iio/adc/mcp3422.c > @@ -382,7 +382,9 @@ static int mcp3422_probe(struct i2c_client *client, > | MCP3422_CHANNEL_VALUE(0) > | MCP3422_PGA_VALUE(MCP3422_PGA_1) > | MCP3422_SAMPLE_RATE_VALUE(MCP3422_SRATE_240)); > - mcp3422_update_config(adc, config); > + err = mcp3422_update_config(adc, config); > + if (err < 0) > + return err; > > err = devm_iio_device_register(&client->dev, indio_dev); > if (err < 0) -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
