Re: [PATCH 1/2] iio: imu: st_lsm6dsx: export st_lsm6dsx_flush_fifo() and st_lsm6dsx_set_fifo_mode() routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/04/17 19:22, Lorenzo Bianconi wrote:
> Remove static qualifier from st_lsm6dsx_flush_fifo() and
> st_lsm6dsx_set_fifo_mode() in order to use them in system sleep pm support
Export kind of implies exporting the symbols when referring to kernel code.
Here you are just making them available to other parts of the same driver.
Perhaps reword the patch title.

Jonathan
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx>
> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h        | 3 +++
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 6 +++---
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> index 4839db7..7778520 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> @@ -144,5 +144,8 @@ int st_lsm6dsx_write_with_mask(struct st_lsm6dsx_hw *hw, u8 addr, u8 mask,
>  			       u8 val);
>  int st_lsm6dsx_update_watermark(struct st_lsm6dsx_sensor *sensor,
>  				u16 watermark);
> +int st_lsm6dsx_flush_fifo(struct st_lsm6dsx_hw *hw);
> +int st_lsm6dsx_set_fifo_mode(struct st_lsm6dsx_hw *hw,
> +			     enum st_lsm6dsx_fifo_mode fifo_mode);
>  
>  #endif /* ST_LSM6DSX_H */
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> index c8e5cfd..b19a62d 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> @@ -130,8 +130,8 @@ static int st_lsm6dsx_update_decimators(struct st_lsm6dsx_hw *hw)
>  	return 0;
>  }
>  
> -static int st_lsm6dsx_set_fifo_mode(struct st_lsm6dsx_hw *hw,
> -				    enum st_lsm6dsx_fifo_mode fifo_mode)
> +int st_lsm6dsx_set_fifo_mode(struct st_lsm6dsx_hw *hw,
> +			     enum st_lsm6dsx_fifo_mode fifo_mode)
>  {
>  	u8 data;
>  	int err;
> @@ -303,7 +303,7 @@ static int st_lsm6dsx_read_fifo(struct st_lsm6dsx_hw *hw)
>  	return read_len;
>  }
>  
> -static int st_lsm6dsx_flush_fifo(struct st_lsm6dsx_hw *hw)
> +int st_lsm6dsx_flush_fifo(struct st_lsm6dsx_hw *hw)
>  {
>  	int err;
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux