On 08/04/17 01:16, Srinivas Pandruvada wrote:
> When a hid sensor module is removed and modprobed again we see
> error for unbalanced pm_runtime. This issue is caused by not
> deactivating runtime PM on removal. So on modprobe again when
> activated again, this will print this error.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
Applied to the togreg branch of iio.git which will be pushed
out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> Not an urgent fix, so targeted for next release only.
>
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index 6082934..0b5dea0 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -152,6 +152,10 @@ static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
>
> void hid_sensor_remove_trigger(struct hid_sensor_common *attrb)
> {
> + pm_runtime_disable(&attrb->pdev->dev);
> + pm_runtime_set_suspended(&attrb->pdev->dev);
> + pm_runtime_put_noidle(&attrb->pdev->dev);
> +
> cancel_work_sync(&attrb->work);
> iio_trigger_unregister(attrb->trigger);
> iio_trigger_free(attrb->trigger);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
