On 30/03/17 14:38, Peter Meerwald-Stadler wrote: > >> On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: >>> Replace a comma between expression statements by a semicolon. This >>> changes the semantics of the code, but given the current indentation >>> appears to be what is intended. > >> You can simply say that this fixes what appears to be a bug to me. >> I wonder how this does even compile.. > > it's valid C and I think it does the correct thing (i.e. assign those > variables); the style is weird obviously Hohum I am clearly going crazy in my old age. Not a bug, but nice to fix so Applied to the togreg branch of iio.git. Sorry for messing my little change up Jacopo! Always worth checking a maintainer isn't being an idiot when they apply your patches. As others will certify we make plenty of mistakes. Jonathan > >> [1] https://marc.info/?l=linux-iio&m=148475728729617&w=2 >> >>> Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx> >>> --- >>> drivers/iio/adc/max11100.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c >>> index 23c060e1b663..1180bcc22ff1 100644 >>> --- a/drivers/iio/adc/max11100.c >>> +++ b/drivers/iio/adc/max11100.c >>> @@ -124,8 +124,8 @@ static int max11100_probe(struct spi_device *spi) >>> indio_dev->name = "max11100"; >>> indio_dev->info = &max11100_info; >>> indio_dev->modes = INDIO_DIRECT_MODE; >>> - indio_dev->channels = max11100_channels, >>> - indio_dev->num_channels = ARRAY_SIZE(max11100_channels), >>> + indio_dev->channels = max11100_channels; >>> + indio_dev->num_channels = ARRAY_SIZE(max11100_channels); >>> >>> state->vref_reg = devm_regulator_get(&spi->dev, "vref"); >>> if (IS_ERR(state->vref_reg)) >>> -- >>> 2.11.0 >>> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
