Hi Alexandre hope you're doing good! On Thu, Mar 30, 2017 at 07:23:12PM +0200, Alexandre Belloni wrote: > On 30/03/2017 at 15:30:46 +0200, jacopo wrote: > > Hi Arushi, > > thanks for your patch > > > > On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > > > Replace a comma between expression statements by a semicolon. This > > > changes the semantics of the code, but given the current indentation > > > appears to be what is intended. > > > A simplified version of the Coccinelle semantic patch that performs this > > > transformation is as follows: > > > > > > // <smpl> > > > @r@ > > > expression e1,e2; > > > @@ > > > > > > e1 > > > -, > > > +; > > > e2; > > > // </smpl> > > > > > > > You can simply say that this fixes what appears to be a bug to me. > > I wonder how this does even compile.. > > > > It is not a bug, it is perfectly valid and working as expected/intended. > This is just a cosmetic change. > > See https://en.wikipedia.org/wiki/Comma_operator if you want to > understand. > Thanks! That's valid and legal (I should have thought at multiple expression in for(;;) as an example). Ignore my comment then (I still don't think it was "intended" as it's quite unusual to see commas there :) Thanks j > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
