Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx> --- drivers/iio/light/si1145.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c index 096034c..e7ad6fb 100644 --- a/drivers/iio/light/si1145.c +++ b/drivers/iio/light/si1145.c @@ -557,7 +557,7 @@ static int si1145_set_chlist(struct iio_dev *indio_dev, unsigned long scan_mask) data->scan_mask = scan_mask; ret = si1145_param_set(data, SI1145_PARAM_CHLIST, reg); - return ret < 0 ? ret : 0; + return min(ret, 0); } static int si1145_measure(struct iio_dev *indio_dev, -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html