On Sun, Mar 19, 2017 at 10:19:42AM +0000, Jonathan Cameron wrote: > On 17/03/17 21:43, Aishwarya Pant wrote: > > In the driver adis16201 read raw does not require an iio_dev->mlock for > > reads. It can run concurrently as adis_read_reg_16() is protected by a > > transaction lock. > > > > Signed-off-by: Aishwarya Pant <aishpant@xxxxxxxxx> > Great, one suggestion for a follow up patch below. > > Applied to the togreg branch of iio.git and pushed out as testing for > the autobuilders to play with it. > > Thanks, > > Jonathan > > > > --- > > Changes in v3: > > -- Fix change log format > > -- Send patch to linuc-iio > > Changes in v2: > > -- Remove read lock > > > > drivers/staging/iio/accel/adis16201.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c > > index d6c8658..fd2baf2 100644 > > --- a/drivers/staging/iio/accel/adis16201.c > > +++ b/drivers/staging/iio/accel/adis16201.c > > @@ -223,17 +223,13 @@ static int adis16201_read_raw(struct iio_dev *indio_dev, > > default: > > return -EINVAL; > > } > > - mutex_lock(&indio_dev->mlock); > > addr = adis16201_addresses[chan->scan_index]; > > ret = adis_read_reg_16(st, addr, &val16); > Not a lot of point in having the local variable addr given it's > only used here. Perhaps you could follow up with a patch getting > rid of it? Sure. I will look at clean-up opportunities here. But I'm unsure of where I should be rebasing from? greg's staging tree or the togreg branch of the iio tree. https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/ According to the link, togreg was last updated 2 weeks ago. thanks Aishwarya > > - if (ret) { > > - mutex_unlock(&indio_dev->mlock); > > + if (ret) > > return ret; > > - } > > val16 &= (1 << bits) - 1; > > val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > > *val = val16; > > - mutex_unlock(&indio_dev->mlock); > > return IIO_VAL_INT; > > } > > return -EINVAL; > > > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
