Re: [PATCH] Staging: iio: cdc: use octal permissions instead of symbolic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/03/17 13:02, Miguel Robles wrote:
> Fix checkpatch warnings:
> Symbolic permissions 'S_IWUSR' are not preferred.
> 
> Signed-off-by: Miguel Robles <miguel.robles@xxxxxxxxxx>
Fine, with the exception that I'd like to see the name of the driver in the
description.

Applied with that added to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/cdc/ad7746.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 81f8b9e..6c688bd 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -351,15 +351,15 @@ static ssize_t ad7746_start_gain_calib(struct device *dev,
>  }
>  
>  static IIO_DEVICE_ATTR(in_capacitance0_calibbias_calibration,
> -		       S_IWUSR, NULL, ad7746_start_offset_calib, CIN1);
> +		       0200, NULL, ad7746_start_offset_calib, CIN1);
>  static IIO_DEVICE_ATTR(in_capacitance1_calibbias_calibration,
> -		       S_IWUSR, NULL, ad7746_start_offset_calib, CIN2);
> +		       0200, NULL, ad7746_start_offset_calib, CIN2);
>  static IIO_DEVICE_ATTR(in_capacitance0_calibscale_calibration,
> -		       S_IWUSR, NULL, ad7746_start_gain_calib, CIN1);
> +		       0200, NULL, ad7746_start_gain_calib, CIN1);
>  static IIO_DEVICE_ATTR(in_capacitance1_calibscale_calibration,
> -		       S_IWUSR, NULL, ad7746_start_gain_calib, CIN2);
> +		       0200, NULL, ad7746_start_gain_calib, CIN2);
>  static IIO_DEVICE_ATTR(in_voltage0_calibscale_calibration,
> -		       S_IWUSR, NULL, ad7746_start_gain_calib, VIN);
> +		       0200, NULL, ad7746_start_gain_calib, VIN);
>  
>  static int ad7746_store_cap_filter_rate_setup(struct ad7746_chip_info *chip,
>  					      int val)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux