On Fri, 2017-03-17 at 01:21 +0000, Song, Hongyan wrote: > Hi, > Thanks for your comments. But I am not sure what your "type" > mean. I mean the connector type, which you use to differentiate the 2 accelerometers. You should export this data instead of changing the name of the sensor. > If you mean "sensor type", I expose it as second ACC, the sensor type > is the same with the exist ACC, > It cannot be used as a distinction. > If you mean the "connection type" I used in the patch, "connection > type" is only defined in HID driver, > It is not a common property in IIO. So not good to expose it out. > > > BR > Song Hongyan > > -----Original Message----- > From: Bastien Nocera [mailto:hadess@xxxxxxxxxx] ; > Sent: Thursday, March 16, 2017 8:02 PM > To: Song, Hongyan <hongyan.song@xxxxxxxxx>; linux-input@vger.kernel.o > rg; linux-iio@xxxxxxxxxxxxxxx > Cc: jikos@xxxxxxxxxx; jic23@xxxxxxxxxx; Pandruvada, Srinivas <sriniva > s.pandruvada@xxxxxxxxx> > Subject: Re: [PATCH] iio: hid: hid-sensor-accel-3d: Add second ACC > sensor support > > On Thu, 2017-03-16 at 18:20 +0800, Song Hongyan wrote: > > As accelerometer sensor becomes more and more popular, there are > > more > > user scenarios have been developed, "Hinge" is a very important > > usecase which needs two accelerometer sensors to calculate the > > included angle of keyboard and screen. > > In this case, two accelerometer sensors will be exposed. > > Currently, > > IIO interface hasn't other way to distinguish two sensors with > > same > > sensor type, except sensor name. So a new sensor name > > "accel_2nd_3d" > > is added for secondary accelerometer sensor. > > > > In HID level, connection type is a good common property to > > differentiate two sensors with same sensor type. > > I've been told in the past not to rely on device names in iio-sensor- > proxy, and this would go against this advice. > > As you have a "type" to export, why not export that instead? > NrybXǧv^){.n+{zn)w* jg ݢj/zޖ2ޙ&)ߡa Ghj:+vw٥ -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
