Hello, > It's a bit obscure, but isn't there the potential to get the check_status > call spitting out text for the wrong read, or potentially miss a status > value entirely? adis_read_reg() function calls spi_sync(), which is inside mutex block, then how will it misread wrong value? Will not spi_sync() help, which also has mutex block in its definition? Otherwise are changes to be made to if condition (val & ADIS16240_ERROR_ACTIVE)?, which depends on the value of val. I understand that we cannot use txrx_lock private lock in adis16240_read_12bit_signed. If the txrx_lock value is set, then it would cause deadlock as in adis_read_reg again, it will try to lock txrx_lock variable. > (kind of more for Lars really, but feel free to comment Varsha!) > > The various faults look like this wouldn't be an issue, but I'm not > totally sure about the SPI failure and whether a following good read > at exactly the wrong time might result in the error not being reported... Was this case eliminated when mutex lock was used before adis16240_spi_read_signed() function call? Thanks, Varsha -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
