Re: [PATCH] [PATCH] Staging: iio: cdc: ad7152.c, use octal permissions instead of symbolic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 15, 2017 at 10:01:58PM +0000, Jonathan Cameron wrote:
> On 14/03/17 15:52, Miguel Robles wrote:
> > Fix checkpatch warnings:
> > Symbolic permissions are not preferred. Consider using octal permissions.
> > 
> > Signed-off-by: Miguel Robles <miguel.robles@xxxxxxxxxx>
> Thanks,
> 
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.
> 
> Thanks,

Great, thank you for applying my first patch :)!
Miguel.
> 
> Jonathan
> > ---
> >  drivers/staging/iio/cdc/ad7152.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> > index e8609b8..dd0c24c 100644
> > --- a/drivers/staging/iio/cdc/ad7152.c
> > +++ b/drivers/staging/iio/cdc/ad7152.c
> > @@ -155,13 +155,13 @@ static ssize_t ad7152_start_gain_calib(struct device *dev,
> >  }
> >  
> >  static IIO_DEVICE_ATTR(in_capacitance0_calibbias_calibration,
> > -		       S_IWUSR, NULL, ad7152_start_offset_calib, 0);
> > +		       0200, NULL, ad7152_start_offset_calib, 0);
> >  static IIO_DEVICE_ATTR(in_capacitance1_calibbias_calibration,
> > -		       S_IWUSR, NULL, ad7152_start_offset_calib, 1);
> > +		       0200, NULL, ad7152_start_offset_calib, 1);
> >  static IIO_DEVICE_ATTR(in_capacitance0_calibscale_calibration,
> > -		       S_IWUSR, NULL, ad7152_start_gain_calib, 0);
> > +		       0200, NULL, ad7152_start_gain_calib, 0);
> >  static IIO_DEVICE_ATTR(in_capacitance1_calibscale_calibration,
> > -		       S_IWUSR, NULL, ad7152_start_gain_calib, 1);
> > +		       0200, NULL, ad7152_start_gain_calib, 1);
> >  
> >  /* Values are Update Rate (Hz), Conversion Time (ms) + 1*/
> >  static const unsigned char ad7152_filter_rate_table[][2] = {
> > 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux