Re: [Outreachy kernel] [PATCH 0/2] staging: iio: accel: Group similar macros into enums

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 05, 2017 at 10:58:29AM -0800, Alison Schofield wrote:
> On Sun, Mar 05, 2017 at 06:26:03PM +0200, Narcisa Ana Maria Vasile wrote:
> > Group related macros into enums, for clarity.
> 
> Hi Narcisa,
> 
> Is this enum then used in a type declaration?
> 
> BTW - I can see Jonathan is following right along and sweeping these up,
> but for future reference, this patch depended on a previous patch sent hours
> earlier, that was not yet in staging-testing.  When this happens, one option
> is to give a note below the --- (as you would for version comments) stating the
> dependency.  This way someone reviewing the patch doesn't simply reject
> it as not applying to my tree.
> 
> alisons
> 
  Hi,

  Do you mean whether there are any type declarations where I could
  now replace the type with the enum type ? If so, I searched for 
  these type of situations, but didn't find any. If I missed one of
  these cases, please let me know and I'll send a new patch.

  Thank you for the note about the patch dependencies. I was just about
  to ask about this, cause I realized there might be a problem.
  I'll keep in mind to make a note next time.

  Narcisa

> > Narcisa Ana Maria Vasile (2):
> >   staging: iio: adis16209: Group similar macros into enums
> >   staging: iio: adis16240: Group similar macros into enums
> > 
> >  drivers/staging/iio/accel/adis16209.c | 18 ++++++++++--------
> >  drivers/staging/iio/accel/adis16240.c | 14 ++++++++------
> >  2 files changed, 18 insertions(+), 14 deletions(-)
> > 
> > -- 
> > 1.9.1
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
> > To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1488730643.git.narcisaanamaria12%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux